wangzhigang1999 commented on PR #7710: URL: https://github.com/apache/kyuubi/pull/7710#issuecomment-5512394028
Thanks for the quick update, and sorry for the churn. I should have caught these issues before your update. The RBAC and grammar changes look good. Could you revert the other two changes? - Requiring the standard token and CA files is too restrictive. `KubernetesUtils` already supports configured authentication, and this check would silently skip initialization for those setups. Keeping the non-empty environment checks is enough. - Filtering an empty namespace to `None` does not fix it because `getKubernetesConf` retains the original empty value. Namespace validation should be handled in the config entry if needed. Sorry again for the extra work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
