littlexyw opened a new pull request, #7669:
URL: https://github.com/apache/kyuubi/pull/7669
…same-millisecond collision
SparkSQLEngine.generateExecutorPodNamePrefixForK8s built the podNamePrefix
as `kyuubi-<user>-<epoch-millis>`. Two engines for the same user launched
within the same millisecond in the same namespace ended up with an identical
`spark.kubernetes.executor.podNamePrefix`, causing their executor pods
(`<prefix>-exec-<id>`) to collide inside the namespace and one of the two apps
to fail creating executors.
Replace the epoch-millis suffix with a UUIDv7 from the existing
`UuidUtils.generateUUIDv7` helper. UUIDv7 keeps the 48-bit epoch millis in its
leading bits so pod names remain roughly time-ordered when listed by name,
while the trailing 74 bits of secure randomness make same-millisecond
collisions essentially impossible. The oversized-user-name fallback path is
switched to the same UUIDv7 for consistency.
Add a concurrent unit test that fans out 1000 prefix generations across 10
threads for the same user and asserts every generated prefix is unique.
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://kyuubi.readthedocs.io/en/master/contributing/code/index.html
2. If the PR is related to an issue in
https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title,
e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new feature, clarify the use cases.
2. If you fix a bug, you can clarify why it is a bug, and what versions
are affected.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
### Was this patch assisted by generative AI tooling?
<!--
If generative AI tooling has assisted in authoring or reviewing this patch,
please include
an 'Assisted-by: ' trailer that identifies the agent and/or model.
For example: 'Assisted-by: Claude Opus 4.7' or 'Assisted-by:
Claude:claude-opus-4-7'.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
