wangzhigang1999 commented on code in PR #7656:
URL: https://github.com/apache/kyuubi/pull/7656#discussion_r3844594342
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -635,6 +635,18 @@ object KyuubiConf {
.immutable
.fallbackConf(FRONTEND_BIND_PORT)
+ val FRONTEND_THRIFT_BINARY_VIRTUAL_THREADS_ENABLED: ConfigEntry[Boolean] =
+ buildConf("kyuubi.frontend.thrift.binary.virtual.threads.enabled")
+ .doc("Whether to use virtual threads for the Kyuubi server thrift binary
frontend " +
+ "workers. This requires Java 21 or later. The maximum number of
concurrent workers " +
Review Comment:
Yes, I also tried a more aggressive version that converted the entire SQL
pipeline—including the Spark SQL engine—to virtual threads.
At that time, I found that synchronous Log4j output caused pinning, which
even led to hangs under the default carrier thread count. Therefore, I
significantly narrowed the scope of the first PR.
Your reminder is crucial. If you also agree that we can introduce virtual
threads, I will conduct benchmarks on larger-scale real-world datasets, which
would make the case more compelling.If necessary, some synchronized blocks can
also be optimized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
