maomaodev commented on code in PR #7476:
URL: https://github.com/apache/kyuubi/pull/7476#discussion_r3811124434
##########
extensions/spark/kyuubi-spark-connector-hive/src/test/scala/org/apache/kyuubi/spark/connector/hive/DynamicPartitionPruningSuite.scala:
##########
@@ -86,19 +90,51 @@ class DynamicPartitionPruningSuite extends KyuubiHiveTest {
| WHERE d.tag = 'target'
|""".stripMargin
+ val df = spark.sql(sql)
checkAnswer(
- spark.sql(sql),
+ df,
Seq(
Row(3, "c", "2026-05-01"),
Row(4, "d", "2026-05-01")))
// DPP being actually applied is observable as a
`DynamicPruningExpression`
// injected into `BatchScanExec.runtimeFilters`.
- val exec = findBatchScanExec(spark, sql, fact.split('.').last)
+ val exec = findBatchScanExec(df.queryExecution.executedPlan,
fact.split('.').last)
val hasDpp =
exec.runtimeFilters.exists(_.isInstanceOf[DynamicPruningExpression])
assert(hasDpp == enabled)
+
+ val planned = exec.scan.toBatch.planInputPartitions().length
+ plannedPartitions(enabled) = planned
+
+ exec.scan match {
+ case _: KyuubiOrcScan | _: KyuubiParquetScan =>
+ assert(exec.scan.columnarSupportMode() ==
Scan.ColumnarSupportMode.SUPPORTED)
Review Comment:
Added four tests in `DynamicPartitionPruningSuite`
* parquet/orc vectorizedReader off → `UNSUPPORTED`.
* parquet/orc all-partitions-pruned via DPP →
`planInputPartitions().isEmpty` then `SUPPORTED`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
