wForget commented on code in PR #7626:
URL: https://github.com/apache/kyuubi/pull/7626#discussion_r3764065783
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -91,9 +91,13 @@ case class SparkSQLEngine(spark: SparkSession) extends
Serverable("SparkSQLEngin
}
if
(backendService.sessionManager.getConf.get(OPERATION_RESULT_SAVE_TO_FILE)) {
- val fs =
engineSavePath.getFileSystem(spark.sparkContext.hadoopConfiguration)
- fs.mkdirs(engineSavePath)
- fs.deleteOnExit(engineSavePath)
+ engineSavePath = Some(backendService.sessionManager
+ .asInstanceOf[SparkSQLSessionManager].getEngineResultSavePath())
Review Comment:
`kyuubi.operation.result.saveToFile.enabled` is a session-level
configuration, but `kyuubi.operation.result.saveToFile.dir` is not. If we want
to retain the ability to enable this feature at the session level, we should
always create and clean up this directory. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
