Copilot commented on code in PR #7620:
URL: https://github.com/apache/kyuubi/pull/7620#discussion_r3742171188
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -577,17 +577,22 @@ class KubernetesApplicationOperation extends
ApplicationOperation with Logging {
}
}
- private def checkPodAppCanceled(kubernetesInfo: KubernetesInfo, pod: Pod):
Unit = {
+ private def cleanupOrphanPodIfBatchTerminated(kubernetesInfo:
KubernetesInfo, pod: Pod): Unit = {
if (kyuubiConf.isRESTEnabled) {
cleanupCanceledAppPodExecutor.submit(new Runnable {
Review Comment:
The executor name `cleanupCanceledAppPodExecutor` (and its thread name) is
now misleading: `cleanupOrphanPodIfBatchTerminated` also handles non-canceled
terminal batches (e.g., ERROR + NOT_FOUND). Consider renaming the
executor/thread to reflect the broader orphan-pod cleanup responsibility to
keep naming consistent with the new method name.
This issue also appears in the following locations of the same file:
- line 588
- line 591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
