pan3793 commented on code in PR #7614:
URL: https://github.com/apache/kyuubi/pull/7614#discussion_r3726476023
##########
build/dist:
##########
@@ -186,6 +186,13 @@ SPARK_VERSION=$("$MVN" help:evaluate
-Dexpression=spark.version $@ 2>/dev/null\
| grep -v "WARNING"\
| tail -n 1)
+BUILD_EXTRA_SPARK_ENGINE=false
+case "$SPARK_VERSION" in
+ 3.3.*|3.4.*|3.5.*)
+ BUILD_EXTRA_SPARK_ENGINE=true
Review Comment:
I feel we should not skip building the Scala 2.12 engine even when passing
`-Pspark-4.x` options. Suppose we are going to change the default Spark version
from 3.5 to Spark 4.x soon, and in the meantime, we are likely to keep support
for Spark 3.5 LTS for a long period, we still want the single tgz to support
both Spark 3.5 and 4.x, so when `scala-2.13` and `spark-4.x` are specified,
replace it with `scala-2.12` and `spark-3.5` to build the extra engine jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
