j1wonpark opened a new pull request, #7569:
URL: https://github.com/apache/kyuubi/pull/7569

   ### Why are the changes needed?
   
   Fixes #7568.
   
   `RuleApplyTypeOfMarker` marks every `TypeOf` in the whole plan 
(`transformAllExpressions`), but since #5997 `RuleEliminateTypeOf` reverts them 
with `transformExpressionsUp`, which only visits the root node's expressions. A 
`TypeOfPlaceHolder` below the root — under `Sort`, `Union`, `Aggregate`, or a 
subquery — survives into execution and fails with 
`CLASS_NOT_OVERRIDE_EXPECTED_METHOD`, since it implements `doGenCode` but no 
`eval`.
   
   This change uses `transformAllExpressions` on the eliminating side as well, 
so both rules cover the same scope in a single pass.
   
   Affects 1.9.0 onwards, including master.
   
   ### How was this patch tested?
   
   Added a test to `RangerSparkExtensionSuite` covering the root shapes the 
existing `Project`-root-only test misses: `Sort`, `Union`, `Aggregate`, and a 
subquery. It fails on master and passes with this change. Full 
`extensions/spark/kyuubi-spark-authz` suite: 657 passed, 0 failed.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Assisted-by: Claude:claude-opus-4-8
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to