wangzhigang1999 commented on PR #7530: URL: https://github.com/apache/kyuubi/pull/7530#issuecomment-4965129119
> Before taking a detailed look, another common use case, in addition to REWRITE/REJECT, is to tune the config. Good point. The current SPI exposes the statement-level conf overlay as read-only, so an interceptor cannot tune it. I am considering letting StatementInterceptResult carry a config-overlay delta. The interceptor chain would accumulate those updates in order, each following interceptor would see the updated overlay, and later values would win. The final overlay would then be passed to the engine operation together with the intercepted statement. I prefer an explicit result delta over making StatementInterceptContext mutable, since config tuning can also be combined with REWRITE and the chain semantics remain clear. Does that match the use case you have in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
