pan3793 commented on code in PR #7521:
URL: https://github.com/apache/kyuubi/pull/7521#discussion_r3570964444
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala:
##########
@@ -338,11 +337,38 @@ class KyuubiSessionManager private (name: String) extends
SessionManager(name) {
getBatchMetadata(batchId)
.filter(m =>
m.kyuubiInstance == kyuubiInstance &&
batchStatesToRecovery.contains(m.opState))
- .flatMap { metadata =>
Some(createBatchSessionFromRecovery(metadata)) }
+ .flatMap(createBatchSessionFromRecoverySafely)
}
}
}
+ private def createBatchSessionFromRecoverySafely(
+ metadata: Metadata): Option[KyuubiBatchSession] = {
+ metadata.requestConf.collectFirst { case (key, null) => key } match {
Review Comment:
what I mean bug fix is, filtering out the null-valued config when creating
the batch ...
I remember having fixed it, seems not to have been pushed to upstream ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
