ulysses-you commented on code in PR #7552:
URL: https://github.com/apache/kyuubi/pull/7552#discussion_r3557526633


##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtension.scala:
##########
@@ -49,6 +50,8 @@ class RangerSparkExtension extends (SparkSessionExtensions => 
Unit) {
     // because ConstantFolding will optimize deterministic UDFs with foldable
     // inputs (e.g., literals), replacing them with their results and 
bypassing permission checks.
     v1.injectCheckRule(RuleFunctionAuthorization)
+    // Clear leaked authz tags from cached catalog nodes before any authz 
resolution rule runs.
+    v1.injectResolutionRule(_ => RuleClearAuthzTag)

Review Comment:
   The resolution rules will apply plan with fixedPoint iterations, so the 
`RuleClearAuthzTag` rule will always cleap up the last round injected tag by 
all authz rules. Is it expected ? According to the comment, do you want inject 
rule in `PostHocResolution`  ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to