ulysses-you opened a new pull request, #7531:
URL: https://github.com/apache/kyuubi/pull/7531
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://kyuubi.readthedocs.io/en/master/contributing/code/index.html
2. If the PR is related to an issue in
https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title,
e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug, and what versions
are affected.
-->
Starting from Spark 3.5, the RebalancePartitions operator supports an
optAdvisoryPartitionSize parameter to specify the desired partition size after
shuffle. This allows Kyuubi to directly control the target output size of the
rebalance shuffle, helping AQE's CoalesceShufflePartitions to produce
appropriately sized output files and avoid small file issues.
Currently, RebalanceBeforeWriting inserts RebalancePartitions without any
advisory size, leaving AQE to use the global
spark.sql.adaptive.advisoryPartitionSizeInBytes which may not be suitable for
the final write stage.
This patch introduces a new Kyuubi configuration key
spark.sql.adaptive.rebalancePartitionsAdvisoryPartitionSizeInBytes that takes
precedence over the final-stage config
spark.sql.finalStage.adaptive.advisoryPartitionSizeInBytes as a fallback.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Added 5 unit tests in RebalanceBeforeWritingSuite covering all scenarios:
- Final-stage config takes effect
- Kyuubi config fallback
- Kyuubi config takes precedence over final-stage when both are set
- Neither config is set (optAdvisoryPartitionSize is None)
- Raw getAdvisoryPartitionSize(conf) config resolution
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has assisted in authoring or reviewing this patch,
please include
an 'Assisted-by: ' trailer that identifies the agent and model.
For example: 'Assisted-by: Claude:claude-opus-4-7' or 'Assisted-by: Claude
Opus 4.7'.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Claude Code (Anthropic Claude Opus 4.7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
