pan3793 commented on code in PR #7516:
URL: https://github.com/apache/kyuubi/pull/7516#discussion_r3420739017


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/SchemaHelper.scala:
##########
@@ -112,6 +118,7 @@ object SchemaHelper {
     case DateType => java.sql.Types.DATE
     case TimestampType => java.sql.Types.TIMESTAMP
     case ntz if ntz.getClass.getSimpleName.equals(TIMESTAMP_NTZ) => 
java.sql.Types.TIMESTAMP
+    case variant if variant.getClass.getSimpleName.equals(VARIANT) => 
java.sql.Types.OTHER

Review Comment:
   VARIANT goes to the default branch even without this change, but it's good 
to write it explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to