pan3793 commented on code in PR #7455:
URL: https://github.com/apache/kyuubi/pull/7455#discussion_r3293470148
##########
extensions/spark/kyuubi-spark-connector-common/src/test/scala/org/apache/kyuubi/spark/connector/common/LocalSparkSession.scala:
##########
@@ -28,12 +28,12 @@ object LocalSparkSession {
System.clearProperty("spark.driver.port")
}
- /** Runs `f` by passing in `sc` and ensures that `sc` is stopped. */
- def withSparkSession[T](sc: SparkSession)(f: SparkSession => T): T = {
+ /** Runs `f` by passing in `spark` and ensures that `spark` is stopped. */
+ def withSparkSession[T](spark: SparkSession)(f: SparkSession => T): T = {
Review Comment:
it's naming fix. we should follow the naming policy defined in
`spark-shell`, `sc` refers to the `SparkContext`, `spark` refers to
`SparkSession`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
