pan3793 commented on code in PR #7436: URL: https://github.com/apache/kyuubi/pull/7436#discussion_r3254992180
########## extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveRuntimeFilterSupport.scala: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.spark.connector.hive.read + +import java.util.Locale + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.catalyst.expressions.{AttributeReference, Expression, In, Literal} +import org.apache.spark.sql.connector.expressions.{Expressions, NamedReference} +import org.apache.spark.sql.hive.kyuubi.connector.HiveBridgeHelper.StructTypeHelper +import org.apache.spark.sql.sources.{Filter, In => FilterIn} +import org.apache.spark.sql.types.StructType + +/** + * Helpers for a Hive-backed V2 [[org.apache.spark.sql.connector.read.Scan]] to + * implement [[org.apache.spark.sql.connector.read.SupportsRuntimeFiltering]] + * for Dynamic Partition Pruning (DPP). + * + * Spark's `DataSourceV2Strategy` currently only emits the `IN` form as a DPP + * runtime filter, so translation here handles `In` only. Any filter whose + * attribute does not match a known partition column is dropped; drops are + * logged at DEBUG. + * + * We deliberately use the V1 `SupportsRuntimeFiltering` instead of the newer + * `SupportsRuntimeV2Filtering` to keep this connector compilable against + * Spark 3.3, where `SupportsRuntimeV2Filtering` was introduced in Spark 3.4. + */ +object HiveRuntimeFilterSupport extends Logging { Review Comment: the logic inside it becomes simple after moving to v1 `SupportsRuntimeFiltering`, do we still need such a helper class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
