wangzhigang1999 commented on code in PR #7451: URL: https://github.com/apache/kyuubi/pull/7451#discussion_r3247023288
########## kyuubi-server/src/main/scala/org/apache/kyuubi/engine/dataagent/DataAgentProcessBuilder.scala: ########## @@ -34,6 +34,7 @@ import org.apache.kyuubi.operation.log.OperationLog import org.apache.kyuubi.util.command.CommandLineUtils._ class DataAgentProcessBuilder( + override val serverConf: KyuubiConf, Review Comment: I don't think adding an extra `serverConf` parameter is a good idea. This would result in two configurations that appear identical except for their names, which could cause significant confusion during usage—users might wonder, "Which configuration should I actually use?" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
