wangzhigang1999 commented on issue #7445: URL: https://github.com/apache/kyuubi/issues/7445#issuecomment-4449457168
Circling back with a concrete draft. To avoid writing it from intuition, I mined Kyuubi's review history first — 4564 PRs scraped, 369 high-signal landed PRs analyzed, 1503 evidence-grounded rule candidates extracted, then manually consolidated into 86 canonical rules across 13 themes. That data made one thing very visible: review here is carried by a handful of extremely active maintainers. | Reviewer | PRs reviewed | Formal reviews | Inline comments | Approvals | |---|---:|---:|---:|---:| | @pan3793 | 1960 | 4009 | 2549 | 1590 | | @yaooqinn | 1395 | 3136 | 1979 | 1204 | | @ulysses-you | 719 | 1242 | 917 | 552 | | @turboFei | 388 | 915 | 620 | 354 | | @bowenliang123 | 323 | 597 | 364 | 275 | | @cxzl25 | 563 | 677 | 167 | 525 | | @cfmcgrady | 267 | 341 | 164 | 205 | | @wForget | 149 | 281 | 175 | 120 | Thank you for the years of patient review — most rules in the draft are literally your words, paraphrased. **Gist (two files):** https://gist.github.com/wangzhigang1999/fddcbc62528b343232ed0898f7fc953a - `AGENTS.md` — proposed draft (~440 lines) - `distilled_conventions.md` — the 86 canonical rules with PR citations and reviewer attribution, for traceability Caveat worth naming: @pan3793 and @yaooqinn cover ~89% of landed-PR review activity, so the draft disproportionately reflects their judgment. Would particularly value review on: 1. **Hard boundaries** (server doesn't depend on engines, engines don't depend on each other, public APIs are cluster-manager-agnostic, no Spark-incompatible SQL, no Thrift wire breaks) — accurate, or are there nuances worth calling out? 2. **AI disclosure** — draft uses `Generated-by: <tool>` (per the existing PR template) and forbids `Co-Authored-By: <AI>` and AI self-references in code/commits. Aligned with Flink/Polaris; happy to change if the community prefers something else. 3. **What's missing** — concurrency and security came up in review history but were too PR-specific to consolidate. Patterns you consistently expect contributors to know probably belong in the draft. If the direction looks OK, I'll open a draft PR placing the file at the repo root. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
