wangzhigang1999 commented on code in PR #7442:
URL: https://github.com/apache/kyuubi/pull/7442#discussion_r3226040856
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/impala/ImpalaSchemaHelper.scala:
##########
@@ -27,4 +27,13 @@ class ImpalaSchemaHelper extends SchemaHelper {
override protected def realToTTypeId: TTypeId = {
TTypeId.DOUBLE_TYPE
}
+
+ // Apache Impala HS2 GetColumns labels the schema column "TABLE_MD" instead
of the
+ // JDBC-spec "TABLE_SCHEM" (Impala upstream issue, not Kyuubi's). Rewrite
the label so
Review Comment:
https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/service/MetadataOp.java#L114
I discovered this issue during testing. I think it might be a typo. You can
refer to the source code above.
The row-population site at L494 even comments // TABLE_SCHEM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
