pan3793 commented on code in PR #7419:
URL: https://github.com/apache/kyuubi/pull/7419#discussion_r3154360134
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperationManager.scala:
##########
@@ -91,7 +93,12 @@ class JdbcOperationManager(conf: KyuubiConf) extends
OperationManager("JdbcOpera
schemaName: String,
tableName: String,
tableTypes: util.List[String]): Operation = {
- val query = dialect.getTablesQuery(catalogName, schemaName, tableName,
tableTypes)
+ val effectiveSchema = if (StringUtils.isBlank(schemaName) || schemaName ==
"%") {
+ session.asInstanceOf[JdbcSessionImpl].effectiveDatabase.orNull
+ } else {
+ schemaName
+ }
+ val query = dialect.getTablesQuery(catalogName, effectiveSchema,
tableName, tableTypes)
Review Comment:
> migrating the dialect API to call DatabaseMetaData directly will touch
every dialect, the operation manager, and every metadata test
if we do that first, do we still need this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
