pan3793 commented on code in PR #7419:
URL: https://github.com/apache/kyuubi/pull/7419#discussion_r3153013881
##########
externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/dialect/JdbcDialect.scala:
##########
@@ -82,6 +82,20 @@ abstract class JdbcDialect extends SupportServiceLoader with
Logging {
def getSchemaHelper(): SchemaHelper
+ /**
+ * Switch the current database on the backend connection.
+ *
+ * Called during session open when the client specified a database in the
connection URL
+ * (populated by the Hive JDBC driver into `USE_DATABASE`). Dialects that
support an
+ * in-session database context switch (e.g. MySQL's `USE db`) should
override this and
+ * return `true` on success; the default is a no-op that returns `false`,
meaning the
+ * backend has no notion of "current database" that applies to this session.
+ *
+ * The return value is used by `JdbcOperationManager` to decide whether the
requested
+ * database can be treated as the effective schema filter for metadata
operations.
+ */
+ def setCurrentDatabase(connection: Connection, database: String): Boolean =
false
Review Comment:
@wangzhigang1999 how about
- replica the API with the JDBC standard API, with an additional leading
`conn: Connection` parameter.
- override the impl for known does not work with JDBC drivers
- don't need to care about the return value, always treat it as if it takes
effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
