LamiumAmplexicaule commented on code in PR #7416:
URL: https://github.com/apache/kyuubi/pull/7416#discussion_r3136652067
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1873,6 +1873,16 @@ object KyuubiConf {
.toSet()
.createWithDefault(Set.empty)
+ val SPARK_FILE_CONFIG_LIST: ConfigEntry[Set[String]] =
+ buildConf("kyuubi.spark.file.config.list")
Review Comment:
Thank you for your review.
My reasoning is that including `.engine.` makes it sound like an engine-side
setting.
However, this feature simply adds Spark keys to the list that Kyuubi checks
when submitting an engine
Given that, I think `kyuubi.session.spark.file.config.list` would be a
better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
