oh0873 commented on code in PR #7408:
URL: https://github.com/apache/kyuubi/pull/7408#discussion_r3119332174
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/ldap/Query.scala:
##########
@@ -56,7 +58,9 @@ object Query {
* @return the current instance of the builder
*/
def filter(filterTemplate: String): Query.QueryBuilder = {
- this.filterTemplate = new ST(filterTemplate)
+ val group = new STGroup()
+ this.filterTemplateGroup = Some(group)
+ this.filterTemplate = new ST(group, filterTemplate)
Review Comment:
Cache is created in `def filter`, but it won't be needed after
`createFilter` that's why I added unload right after `createFilter`. I'm not
sure if this is the best place to unload.
At least in our use case it seems to unload most if not all STToken used by
LDAP auth process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
