aajisaka commented on code in PR #7374:
URL: https://github.com/apache/kyuubi/pull/7374#discussion_r3043387097
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/InternalSecurityAccessor.scala:
##########
@@ -69,11 +63,17 @@ class InternalSecurityAccessor(conf: KyuubiConf, val
isServer: Boolean) {
}
private[authentication] def encrypt(value: String): String = synchronized {
- byteArrayToHexString(encryptor.doFinal(value.getBytes))
+ val nonce = new Array[Byte](cryptoIvLength)
+ InternalSecurityAccessor.random.nextBytes(nonce)
+ encryptor.init(Cipher.ENCRYPT_MODE, secretKeySpec, new
IvParameterSpec(nonce))
+ byteArrayToHexString(nonce ++ encryptor.doFinal(value.getBytes))
}
private[authentication] def decrypt(value: String): String = synchronized {
- new String(decryptor.doFinal(hexStringToByteArray(value)))
+ val bytes = hexStringToByteArray(value)
Review Comment:
Fixed in
https://github.com/apache/kyuubi/pull/7374/commits/abfe628643535cf0ff011b104389de43aa9c89b1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
