wangzhigang1999 opened a new pull request, #7381: URL: https://github.com/apache/kyuubi/pull/7381
## Summary Part 2a of 4 for the Data Agent Engine ([umbrella](https://github.com/apache/kyuubi/issues/7379)). **Stacked on #7380, please review that first.** Pure Java layer: tool system, data source abstraction, and prompt templates. - `SqlQueryTool` with maxRows enforcement (hard limit 1000), output truncation (64KB), cell truncation (500 chars) - `ToolRegistry` with JSON schema generation for LLM function calling - `DataSourceFactory` with HikariCP, `JdbcDialect` auto-detection (Spark/SQLite/MySQL/Trino) - `SystemPromptBuilder` — composable prompt with per-dialect templates > **Note**: This PR is stacked on #7380. The diff includes PR1 changes. After #7380 merges, this PR will be rebased and the diff will shrink to only the incremental changes. ## Test plan - [x] `SqlQueryToolTest` — maxRows, truncation, NULL rendering, pipe escaping, error formatting, timeout - [x] `ToolTest` / `ToolSchemaGeneratorTest` / `ToolRegistryThreadSafetyTest` - [x] `DataSourceFactoryAuthTest` / `JdbcDialectTest` - [x] `SystemPromptBuilderTest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
