Copilot commented on code in PR #13214:
URL: https://github.com/apache/ignite/pull/13214#discussion_r3362538388
##########
modules/extdata/pluggable/pom.xml:
##########
@@ -100,6 +100,17 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <systemPropertyVariables>
+ <java.util.logging.config.file>
+
${project.basedir}/src/test/resources/config/java.util.logging.properties
+ </java.util.logging.config.file>
+ </systemPropertyVariables>
Review Comment:
The value for `java.util.logging.config.file` is split across multiple
lines/indented. Maven plugin configuration text can preserve leading/trailing
whitespace/newlines, which risks passing an invalid path to the JVM. Also,
pointing at `src/test/resources` is less robust than using the copied
test-resources location.
##########
modules/extdata/pluggable/src/test/resources/config/java.util.logging.properties:
##########
@@ -0,0 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+handlers=java.util.logging.ConsoleHandler
+.level=INFO
+
+java.util.logging.ConsoleHandler.formatter=org.apache.ignite.logger.java.JavaLoggerFormatter
Review Comment:
The test JUL config references
`org.apache.ignite.logger.java.JavaLoggerFormatter`, which can still trigger
`ClassNotFoundException` in environments where Ignite classes aren’t visible to
`java.util.logging.LogManager` at configuration-load time (the same
classloading problem this PR is trying to avoid). Using a JDK formatter (or
omitting the formatter line) keeps the config self-contained and avoids CNFEs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
