Lalant commented on code in PR #7988:
URL: https://github.com/apache/ignite-3/pull/7988#discussion_r3092692961
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -4127,6 +4143,39 @@ private Future<?>
startChangePeersAndLearnersThread(ChangeArg arg) {
});
}
+ private void changePeersAndLearnersWithRetry(Configuration conf, long
timeoutMillis) throws InterruptedException {
+ Status lastStatus = null;
+ long deadlineNanos = System.nanoTime() +
TimeUnit.MILLISECONDS.toNanos(timeoutMillis);
+
+ while (System.nanoTime() < deadlineNanos) {
Review Comment:
The reason is that the ticket was originally created for a single failing
test testJoinNodes. Later, I noticed a couple of additional failing tests that
looked similar at first glance, so I just linked them.
However, once I started digging into them, it turned out they were slightly
different issues. I didn’t want to postpone them, so I fixed everything
together.
As a result, this change actually includes fixes for three different tests.
- testJoinNodes
- testChangePeersAndLearnersChaosApplyTasks
- testReelectionWithTimeoutNow
Indeed testJoinNodes doesn't use this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
