Vladsz83 commented on code in PR #12827:
URL: https://github.com/apache/ignite/pull/12827#discussion_r2896548948


##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java:
##########
@@ -168,5 +197,17 @@ public class DiscoveryMessageFactory implements 
MessageFactoryProvider {
             new TxTimeoutOnPartitionMapExchangeChangeMessageSerializer());
         factory.register((short)510, UserAcceptedMessage::new, new 
UserAcceptedMessageSerializer());
         factory.register((short)511, UserProposedMessage::new, new 
UserProposedMessageSerializer());
+
+        factory.register((short)520, SnapshotOperationResponse::new, new 
SnapshotOperationResponseSerializer());

Review Comment:
   If we do smth/ like this (the messages reuse) , 
`TcpDiscoveryNodeMetricsMessage`, `TcpDiscoveryCacheMetricsMessage`, 
`TcpDiscoveryNodeFullMetricsMessage` should be reverted too. Look for "We 
cannot directly reuse {@link".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to