chesnokoff commented on code in PR #12848:
URL: https://github.com/apache/ignite/pull/12848#discussion_r2895251527
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/localtask/DurableBackgroundTasksProcessorSelfTest.java:
##########
@@ -345,7 +346,10 @@ public void testConvertAfterRestoreIfNeeded() throws
Exception {
n = startGrid(0);
- assertEquals(3, tasks(n).size());
+ int tasks = tasks(n).size();
Review Comment:
@alex-plekhanov Thanks for notion about new fail in this test, it was not
reproduced by my local machine and on tc. It can be reproduced if we put
`doSleep(5_000)` before the assertion. The reason is that checkpoint deletes
completed task `t0` (see DurableBackgroundTasksProcessor#onMarkCheckpointBegin
where we make `it.remove()`). So there is race condition between the assertion
and checkpoint
I suggest updating statement to assert and providing clear message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
