ivanzlenko commented on code in PR #7638:
URL: https://github.com/apache/ignite-3/pull/7638#discussion_r2839452934
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageManager.java:
##########
@@ -192,6 +201,9 @@ private void start() throws Exception {
);
try {
+ dbOptions.setEnv(env);
Review Comment:
We should rename the variable on line 213 then.
It's just a safety measure. Imagine someone will later modify this part of
code and will use env thinking that they accessing class field, rather than
local var.
Also it is feels just like a bug. Why not setup already existing object?
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/VolatileLogStorageManagerCreator.java:
##########
@@ -109,6 +121,11 @@ public CompletableFuture<Void> startAsync(ComponentContext
componentContext) {
);
try {
+ sstFileManager = new SstFileManager(env);
+
+ dbOptions.setEnv(env);
Review Comment:
The same issue with shadowing of env field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
