arcolight commented on code in PR #7631:
URL: https://github.com/apache/ignite-3/pull/7631#discussion_r2826477349
##########
modules/platforms/cpp/tests/client-test/main.cpp:
##########
@@ -55,6 +55,11 @@ void set_process_abort_handler(std::function<void(int)>
handler) {
signal(SIGABRT, signal_handler);
signal(SIGINT, signal_handler);
signal(SIGSEGV, signal_handler);
+
+#ifndef _WIN32
Review Comment:
Why only this signal is under #ifdef? Let be consistent and call it as a
previous signal calls.
##########
modules/platforms/cpp/ignite/network/detail/linux/sockets.h:
##########
@@ -24,6 +24,10 @@
# define SOCKET_ERROR (-1)
#endif // SOCKET_ERROR
+#ifndef MSG_NOSIGNAL
+# define MSG_NOSIGNAL 0
Review Comment:
I'm not sure we have to redefine POSIX macro values. It is better to fail
compilation than redefine it to some constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
