zstan commented on code in PR #12675:
URL: https://github.com/apache/ignite/pull/12675#discussion_r2758293252
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteScalarFunction.java:
##########
@@ -26,28 +26,41 @@
* Implementation of {@link ScalarFunction} for Ignite user defined functions.
*/
public class IgniteScalarFunction extends IgniteReflectiveFunctionBase
implements ScalarFunction {
+ /** */
+ private boolean deterministic;
Review Comment:
i see it can be final ?
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteScalarFunction.java:
##########
@@ -26,28 +26,41 @@
* Implementation of {@link ScalarFunction} for Ignite user defined functions.
*/
public class IgniteScalarFunction extends IgniteReflectiveFunctionBase
implements ScalarFunction {
+ /** */
+ private boolean deterministic;
+
/**
* Private constructor.
*/
- private IgniteScalarFunction(Method method, CallImplementor implementor) {
+ private IgniteScalarFunction(Method method, CallImplementor implementor,
boolean deterministic) {
super(method, implementor);
+
+ this.deterministic = deterministic;
Review Comment:
do we need mock? tests for such a case ? Can you exted java doc - what
unexpected behavior will be raised if this flag missconfigured ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
