zstan commented on code in PR #12660:
URL: https://github.com/apache/ignite/pull/12660#discussion_r2741242918
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/jdbc/JdbcSetClientInfoTest.java:
##########
@@ -41,35 +43,72 @@
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.jetbrains.annotations.Nullable;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import static org.junit.Assume.assumeFalse;
/** */
+@RunWith(Parameterized.class)
public class JdbcSetClientInfoTest extends GridCommonAbstractTest {
/** */
private static final String SESSION_ID = "sessionId";
/** */
private static final String URL = "jdbc:ignite:thin://127.0.0.1";
+ /** */
+ @Parameterized.Parameter
+ public boolean runInTx;
+
+ /** */
+ @Parameterized.Parameter(1)
+ public CacheAtomicityMode cacheMode;
+
+ /** */
+ @Parameterized.Parameters(name = "runInTx={0}, mode={1}")
+ public static Collection<Object[]> data() {
+ return F.asList(
+ new Object[] { false, CacheAtomicityMode.TRANSACTIONAL },
Review Comment:
use GridTestUtils.cartesianProduct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
