AMashenkov commented on code in PR #7471:
URL: https://github.com/apache/ignite-3/pull/7471#discussion_r2727688677
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/CorrelatedNestedLoopJoinNode.java:
##########
@@ -77,20 +80,22 @@ private enum State {
/**
* Creates CorrelatedNestedLoopJoin node.
*
- * @param ctx Execution context.
+ * @param ctx Execution context.
* @param cond Join expression.
- * @param correlationIds Set of collections ids.
+ * @param correlationIds Set of correlation ids.
* @param joinType Join rel type.
* @param rightRowFactory Right row factory.
* @param joinProjection Output row factory.
+ * @param correlationColumns Set of columns that are used by correlation.
*/
public CorrelatedNestedLoopJoinNode(
ExecutionContext<RowT> ctx,
BiPredicate<RowT, RowT> cond,
Set<CorrelationId> correlationIds,
JoinRelType joinType,
RowFactory<RowT> rightRowFactory,
- SqlJoinProjection joinProjection
+ SqlJoinProjection joinProjection,
+ ImmutableBitSet correlationColumns
Review Comment:
I'd make this parameter followed `correlationIds`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
