wernerdv commented on code in PR #12614:
URL: https://github.com/apache/ignite/pull/12614#discussion_r2681492684
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java:
##########
@@ -1383,6 +1393,21 @@ private void checkAttributes(Iterable<ClusterNode>
nodes) throws IgniteCheckedEx
", locNodeId=" + locNode.id() + ", rmtNode=" +
U.toShortString(n) + "]");
}
}
+
+ WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE);
+
+ if (locWalMode != rmtWalMode) {
+ throw new IgniteCheckedException("WAL mode validation failed.
" +
Review Comment:
I suggest making the error message consistent with existing ones, for
example:
```
throw new IgniteCheckedException("Remote node has WAL mode
different from local " +
"[locId8=" + U.id8(locNode.id()) + ", locWalMode=" +
locWalMode +
", rmtId8=" + U.id8(n.id()) + ", rmtWalMode=" +
rmtWalMode +
", rmtAddrs=" + U.addressesAsString(n) + ", rmtNode=" +
U.toShortString(n) + "]");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
