tkalkirill commented on code in PR #6673:
URL: https://github.com/apache/ignite-3/pull/6673#discussion_r2394423655
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java:
##########
@@ -116,6 +116,8 @@ public class PersistentPageMemoryStorageEngine extends
AbstractPageMemoryStorage
private volatile ExecutorService destructionExecutor;
+ private volatile ExecutorService asyncIoExecutor;
Review Comment:
Please mark that can be `null` (with `@Nullable`) with an explanation why.
I propose to rename it to `asyncFileIoExecutor`.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/AbstractFilePageStoreIo.java:
##########
@@ -292,6 +293,7 @@ void ensure() throws IgniteInternalCheckedException {
while (true) {
try {
this.fileIo = fileIo =
ioFactory.create(filePath, CREATE, READ, WRITE);
+ var fileI1 = ioFactory.create(filePath, new
OpenOption[0]);
Review Comment:
Let's get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
