chesnokoff commented on code in PR #12301:
URL: https://github.com/apache/ignite/pull/12301#discussion_r2358036832
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -1703,10 +1704,24 @@ private boolean notifyDiscovery(int type, long topVer,
TcpDiscoveryNode node, Sp
NavigableMap<Long, Collection<ClusterNode>> hist =
updateTopologyHistory(topVer, top);
- lsnr.onDiscovery(
+ IgniteFuture<?> fut = lsnr.onDiscovery(
Review Comment:
I have not implemented test for this because I think usually there will no
be race condition with `discovery().allNodes()`. It can be reproduced only for
high load systems. For instance when five nodes are trying to connect to slow
master at the same time. I think usually TCP communication will save us from
the race
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
