sergey-chugunov-1985 commented on code in PR #12335:
URL: https://github.com/apache/ignite/pull/12335#discussion_r2348964326
##########
modules/core/src/main/java/org/apache/ignite/internal/direct/stream/DirectByteBufferStream.java:
##########
@@ -862,6 +864,16 @@ public void writeKeyCacheObject(KeyCacheObject keyObj) {
}
}
+ /**
+ * @param val Value.
+ */
+ public void writeGridLongList(@Nullable GridLongList val) {
Review Comment:
I think this implementation could use the fact that `writeLongArray(long[]
arr, int len)` performs internal null check for the first argument and writes
`-1` if null was passed.
From that perspective it may make sense to get rid of these two methods in
`DirectByteBufferStream` and move logic of creating `GridLongList` instances to
`DirectMessageReader`/`DirectMessageWriter` implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
