sergey-chugunov-1985 commented on PR #12305:
URL: https://github.com/apache/ignite/pull/12305#issuecomment-3242541654

   I think we should be able to modify `SocketTimeoutObject` class itself 
instead of creating a wrapper around it.
   
   Just add an `addTimeoutObject(this);` to its constructor and implement an 
`AutoClosable` interface with `removeTimeoutObject(this);` in it along with 
other logic to throw an exception, and we should get the same behavior.
   
   Does it make sense to you?
   
   As far as I can see `SocketTimeoutObject` is a class private to 
`TcpDiscoverySpi` and is used only in these three contexts you touched in your 
PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to