sergey-chugunov-1985 commented on PR #12306: URL: https://github.com/apache/ignite/pull/12306#issuecomment-3242664752
I found one more promising place for improvement with this `writeTo` set of methods. Take a look at the method that declares a `byte[]` as a parameter. There is exactly one. It has another parameter of type `TcpDiscoveryAbstractMessage` which is never used in the method's body. I wonder if we could remove this parameter and not break tests which override the method extensively (but I didn't find one where this particular method is crusial for test's logic) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
