AMashenkov commented on code in PR #6479:
URL: https://github.com/apache/ignite-3/pull/6479#discussion_r2313417678
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/Accumulators.java:
##########
@@ -100,6 +102,8 @@ private Supplier<Accumulator>
accumulatorFunctionFactory(DataContext context, Ag
assert lit instanceof RexLiteral : "Non-literal argument for
LiteralAgg: " + call + ", argument: " + lit;
return LiteralVal.newAccumulator(context, (RexLiteral) lit);
Review Comment:
Just for simplicity.
Agree, execution nodes (reduce aggregates) could enrich output row with
function results.
We should support this semantic in Logical plan due to consistency reasons,
but it seems tricky for me at first glance.
Would it be ok to make an optimization in a separate ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
