sashapolo commented on code in PR #6478:
URL: https://github.com/apache/ignite-3/pull/6478#discussion_r2301494239
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java:
##########
@@ -292,7 +293,7 @@ private CompletableFuture<Void>
invokeMessage(Collection<ClusterNode> nodes, Net
var errorResponse = (InitErrorMessage)
response;
throw new InternalInitException(
- String.format("Got error response from
node \"%s\": %s", node.name(), errorResponse.cause()),
+
Optional.ofNullable(errorResponse.cause()).orElse(""),
Review Comment:
> InitErrorMessage.cause() is marked as nullable, but the first parameter of
the InternalInitException constructor isn't. It got flagged during commit
analysis.
ok
> I don't know if there is a way to selectively print the node name in the
server log, but not show it at the CLI.
Well, you call `LOG.warn` and it will print the message in the server logs =)
> Perhaps, but it would perhaps be better to take it up as a general cleanup
exercise in a separate ticket?
I don't understand, there are two similar messages in two branches of the
same `if` statement. Why did you change only one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
