adityamukho commented on code in PR #6477:
URL: https://github.com/apache/ignite-3/pull/6477#discussion_r2297656308
##########
modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/snapshot/RocksSnapshotManager.java:
##########
Review Comment:
Does the new version of Spotbugs complain here (before moving the
`ReadOptions` parameter out of the method)? What does it say?
##########
check-rules/spotbugs-excludes.xml:
##########
@@ -57,6 +57,12 @@
<Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN"/>
<!-- we specifically catch even not thrown exceptions is some places to
be extra defendant -->
<Bug pattern="REC_CATCH_EXCEPTION"/>
+ <!-- We assume 64-bit writes to be atomic. -->
+ <Bug pattern="AT_NONATOMIC_64BIT_PRIMITIVE"/>
Review Comment:
This is not necessarily true for 32 bit architectures. Do we support 32 bit
architectures?
##########
check-rules/spotbugs-excludes.xml:
##########
@@ -57,6 +57,12 @@
<Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN"/>
<!-- we specifically catch even not thrown exceptions is some places to
be extra defendant -->
<Bug pattern="REC_CATCH_EXCEPTION"/>
+ <!-- We assume 64-bit writes to be atomic. -->
+ <Bug pattern="AT_NONATOMIC_64BIT_PRIMITIVE"/>
+ <!-- These rules fail a lot because they consider some classes to be not
thread safe even when they are used with external
+ synchronization or are not used in multithreaded environment at
all. -->
+ <Bug pattern="AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE"/>
+ <Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
Review Comment:
This looks like a useful check for multi-threaded cases where external sync
was somehow missed.
Could this check be suppressed some other way, such as a code comment in
places where the author has manually ensured thread-safety through external
mechanisms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
