timoninmaxim commented on code in PR #12216:
URL: https://github.com/apache/ignite/pull/12216#discussion_r2297391234


##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/clients/JavaThinCompatibilityTest.java:
##########
@@ -402,7 +403,7 @@ private void testContinuousQueries() throws Exception {
         try (IgniteClient client = Ignition.startClient(new 
ClientConfiguration().setAddresses(ADDR))) {
             ClientCache<Object, Object> cache = 
client.getOrCreateCache("testContinuousQueries");
 
-            List<CacheEntryEvent<?, ?>> allEvts = new ArrayList<>();

Review Comment:
   Looks like, using a CountDownLatch(3) is enough.
   
   You don't use any queue features in the test, you actually need a counter. 
Also using `.size()` for concurrent collections is a bad practice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to