shishkovilja commented on code in PR #12201:
URL: https://github.com/apache/ignite/pull/12201#discussion_r2293976607
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java:
##########
Review Comment:
Methods `#wrtiteTo` and `readFrom` was not removed.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicUpdateResponse.java:
##########
@@ -49,42 +48,46 @@ public class GridNearAtomicUpdateResponse extends
GridCacheIdMessage implements
public static final int CACHE_MSG_IDX = nextIndexId();
/** Node ID this reply should be sent to. */
- @GridDirectTransient
private UUID nodeId;
/** Future ID. */
+ @Order(value = 4, method = "futureId")
private long futId;
/** */
+ @Order(value = 5, method = "errors")
private UpdateErrors errs;
/** Return value. */
@GridToStringInclude
+ @Order(value = 6, method = "returnValue")
private GridCacheReturn ret;
/** */
+ @Order(value = 7, method = "remapTopologyVersion")
private AffinityTopologyVersion remapTopVer;
/** Data for near cache update. */
+ @Order(8)
private NearCacheUpdates nearUpdates;
/** Partition ID. */
- private int partId = -1;
+ @Order(value = 9, method = "partition")
+ private int partId;
/** */
- @GridDirectCollection(UUID.class)
@GridToStringInclude
+ @Order(value = 10, method = "mapping")
private List<UUID> mapping;
/** */
- @GridDirectTransient
private boolean nodeLeft;
/**
* Empty constructor.
*/
public GridNearAtomicUpdateResponse() {
- // No-op.
+ partId = -1;
Review Comment:
As I see, partId is set only in constructor and in serializer.
Does it look like redundant initialization?
Also there can be redundant checks of partId value '-1' in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
