tkalkirill commented on code in PR #6454:
URL: https://github.com/apache/ignite-3/pull/6454#discussion_r2287883661
##########
modules/core/src/main/java/org/apache/ignite/internal/thread/IgniteThreadFactory.java:
##########
@@ -44,7 +44,7 @@ public class IgniteThreadFactory implements ThreadFactory {
/**
* Constructor.
*/
- private IgniteThreadFactory(String nodeName, String poolName, boolean
daemon, IgniteLogger log, ThreadOperation[] allowedOperations) {
+ protected IgniteThreadFactory(String nodeName, String poolName, boolean
daemon, IgniteLogger log, ThreadOperation[] allowedOperations) {
Review Comment:
> Please make the second constructor protected as well.
Ok.
> Why don't you use that constructor by the way? It has a full set of
fields, unlike this one
It doesn't have a node name, but the one used does, which is more convenient
for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
