sanpwc commented on code in PR #6413:
URL: https://github.com/apache/ignite-3/pull/6413#discussion_r2287257360
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/configuration/TransactionConfigurationSchema.java:
##########
@@ -39,7 +41,7 @@ public class TransactionConfigurationSchema {
@Range(min = 1)
@Value(hasDefault = true)
@PublicName(legacyNames = "readWriteTimeout")
- public final long readWriteTimeoutMillis = TimeUnit.SECONDS.toMillis(30);
+ public final long readWriteTimeoutMillis =
TimeUnit.SECONDS.toMillis(DEFAULT_RW_TX_TIMEOUT_SECONDS);
Review Comment:
What's the point of introducing `IgniteTransactionDefaults`?
TransactionConfiguration should be an only source of truth for txTimeout
(which should have default default value if not initialized), thus direct usage
of `DEFAULT_RW_TX_TIMEOUT_SECONDS` like
`long initialTimeout = options == null ?
TimeUnit.SECONDS.toMillis(DEFAULT_RW_TX_TIMEOUT_SECONDS) :
options.timeoutMillis();` should be prohibited.
Can we use `InternalTxOptions.defaults()` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
