xtern commented on code in PR #6418:
URL: https://github.com/apache/ignite-3/pull/6418#discussion_r2284383531
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/Cloner.java:
##########
@@ -85,14 +94,29 @@ public IgniteRel visit(IgniteRel rel) {
// Take into account only actual source relations.
SourceAwareIgniteRel src = (SourceAwareIgniteRel) rel;
- int sourceId = sourceIndex++;
+ long sourceId = sourceIndex++;
Review Comment:
this change looks useless without changing type of `int sourceIndex`
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -757,16 +794,16 @@ private RelWithMetadata doOptimize(
// cluster keeps a lot of cached stuff that won't be used anymore.
// In order let GC collect that, let's reattach tree to an empty
cluster
// before storing tree in plan cache
- IntObjectPair<IgniteRel> pair =
Cloner.cloneAndAssignSourceId(igniteRel, Commons.emptyCluster());
- int numTables = pair.firstInt();
- IgniteRel rel = pair.right();
-
- PartitionAwarenessMetadata partitionAwarenessMetadata =
- PartitionAwarenessMetadataExtractor.getMetadata(rel);
Review Comment:
Can we also remove corresponding `getMetadata` method from
`PartitionAwarenessMetadataExtractor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
