Phillippko commented on code in PR #6343:
URL: https://github.com/apache/ignite-3/pull/6343#discussion_r2284575068
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointDirtyPages.java:
##########
@@ -177,6 +177,22 @@ public PersistentPageMemory pageMemory() {
public int size() {
return toPosition - fromPosition;
}
+
+ /** Returns number of modified (not newly allocated) pages. */
Review Comment:
```
if (!equalsByGroupAndPartition(startPageId, pageIds[fromIndex])) {
return null;
}
```
In main branch we don't support views without dirty pages
Added test case (to
testPageIndexesForDeltaFilePageStoreWithPartitionMetaPage) when only meta page
is present in the view, updated javadoc, added groupId/partitionId parameters
No, fromPosition is not related to partition's persisted pages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
