denis-chudov commented on code in PR #6419:
URL: https://github.com/apache/ignite-3/pull/6419#discussion_r2276324117
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/ReplicatorGroupImpl.java:
##########
@@ -119,14 +122,16 @@ public boolean addReplicator(final PeerId peer, final
ReplicatorType replicatorT
assert client != null;
if (!client.connect(peer)) {
- if (!failureReplicators.containsKey(peer)) {
+ boolean added =
failureReplicatorsSetToPreventLogFlooding.add(peer);
+
+ if (added) {
LOG.error("Fail to check replicator connection to peer={},
replicatorType={}.", peer, replicatorType);
}
this.failureReplicators.put(peer, replicatorType);
return false;
} else {
- failureReplicators.remove(peer);
+ failureReplicatorsSetToPreventLogFlooding.remove(peer);
Review Comment:
Why have you completely removed this line `failureReplicators.remove`? You
still add the replicator to `failureReplicators` in `if` block but now don't
remove in `else`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
