timoninmaxim commented on code in PR #317:
URL: https://github.com/apache/ignite-extensions/pull/317#discussion_r2274190524
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/IgniteToPostgreSqlCdcApplier.java:
##########
@@ -364,27 +272,33 @@ public long applyCacheEvents(Iterator<CdcCacheEvent>
evts, boolean createTables)
while (evts.hasNext()) {
evt = evts.next();
- if (evt.queryEntities().size() != 1)
- throw new IgniteException("There should be exactly 1
QueryEntity for cacheId: " + evt.cacheId());
+ try {
+ if (evt.queryEntities().size() != 1)
+ throw new IgniteException("There should be exactly 1
QueryEntity for cacheId: " + evt.cacheId());
Review Comment:
You throw it within try-catch block intenionally?
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java:
##########
@@ -0,0 +1,221 @@
+package org.apache.ignite.cdc.postgresql;
+
+import java.math.BigDecimal;
+import java.sql.PreparedStatement;
+import java.sql.Types;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.UUID;
+import org.apache.ignite.IgniteException;
+
+import static
org.apache.ignite.cdc.postgresql.JavaToSqlTypeMapper.JavaToSqlType.OBJECT;
+
+/** */
+class JavaToSqlTypeMapper {
+ /** */
+ private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new
HashMap<>();
+
+ static {
+ for (JavaToSqlType type : JavaToSqlType.values())
+ JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type);
+ }
+
+ /**
+ * Sets a value in the PreparedStatement at the given index using the
appropriate setter
+ * based on the runtime type of the object.
+ * @param stmt {@link PreparedStatement}
+ * @param idx value index in {@link PreparedStatement}
+ * @param obj value
+ */
+ public void setValue(PreparedStatement stmt, int idx, Object obj) {
+ try {
+ if (obj == null) {
+ stmt.setNull(idx, Types.NULL);
Review Comment:
replace with assert then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
